-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --skip-empty for coverage report #24
Conversation
This is a better alternative to not running coverage against __init__.py files entirely. This could've been a problem if those files had code in it.
Coverage Report Results
3 empty files skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered --skip-covered
instead, so that this shows only files which need work?
Thanks for the suggestion, I will have a look with more detail.
EDIT: This looks a good addition for when we get to 100% coverage. So the bot can be conditional to only posting on PRs that decrease coverage. |
This is a better alternative to not running coverage against init.py files entirely. This could've been a problem if those files had code in it.