Small code improvements to the cache layer - #625
Merged
Conversation
The function apc_cache_store_internal() internally calls apc_cache_wlocked_insert(), but it doesn't acquire the required wlock. Therefore, it has been renamed to apc_cache_wlocked_store_internal() to indicate that a write lock has to be acquired by the caller.
The TTL is passed as zend_long to the APCu functions and stored as zend_long within the entries. There is no reason to treat this value as an int32_t or uint32_t at any point in between.
Since PHP 7.0, the hash of a string is stored within the zend_string structure. This means that it is not necessary to pass the hash to a function in addition to the zend_string itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.