feat: address config entry cache conflict#123
Open
XD-Builder wants to merge 1 commit intokrbaker:mainfrom
Open
feat: address config entry cache conflict#123XD-Builder wants to merge 1 commit intokrbaker:mainfrom
XD-Builder wants to merge 1 commit intokrbaker:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses config entry cache conflict without modifying unique_id, which I now learn can cause ALL sorts of problems. This change seeks to only add a cache and verifies that it supports multi-location. The additional location field is only used for ensure the location is displayed with a location name and has no actual id level differences. I'm seeing _2 for probably due to my previous set up. @krbaker would you be able to verify this simple change and see if it does not create
_2id for you? Thank you!