Process all batches for large text inputs #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`KotkiTranslationModel::translate` only processed a single batch of text. When a large input string was provided, it was correctly segmented into multiple batches by the `TextProcessor` and enqueued. However, the `translate` function would only generate and translate the first batch, leaving the remaining segments unprocessed in the `BatchingPool`. This resulted in an incomplete translation, where `request->response.target.text` would remain empty because the `ResponseBuilder` was never triggered for the full set of segments. This commit resolves the issue by introducing a loop in the `translate` function. Fixes kroketio#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KotkiTranslationModel::translateonly processed a single batch of text. When a large input string was provided, it was correctly segmented into multiple batches by theTextProcessorand enqueued. However, thetranslatefunction would only generate and translate the first batch, leaving the remaining segments unprocessed in theBatchingPool.This resulted in an incomplete translation, where
request->response.target.textwould remain empty because theResponseBuilderwas never triggered for the full set of segments.This commit resolves the issue by introducing a loop in the
translatefunction.Fixes #8