Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying MLFlow predictors #74

Closed
wants to merge 1 commit into from

Conversation

rvalkenaers
Copy link
Contributor

Currently MLFlow predictors cannot be handled by the web app but they are supported by kserve: https://kserve.github.io/website/0.10/modelserving/v1beta1/mlflow/v2/

This PR adds MLFlow to the list of predictor types.

@rvalkenaers
Copy link
Contributor Author

/assign @yuzisun

@kimwnasptd
Copy link
Contributor

Thanks @rvalkenaers!

/lgtm
/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, rvalkenaers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvalkenaers
Copy link
Contributor Author

@kimwnasptd

The "Fronted Test / Code format and lint" check is failing but it does not seem to be related to my change:

prettier requires at least version 14 of Node, please upgrade

Is this something you could look into?

@AlessandroColantonio
Copy link

Hello, I am new to KServe and this PR fixes the issue I am currently having with MLflow. Is there any plan to close it in the near future? Thank you!

@kimwnasptd
Copy link
Contributor

@rvalkenaers could you rebase your PR, now that #77 is merged?

@hansinikarunarathne
Copy link
Contributor

hansinikarunarathne commented Sep 15, 2024

@juliusvonkohout you can close this PR. Because we merged the PR #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants