Skip to content

Conversation

@vnikolova
Copy link
Collaborator

@vnikolova vnikolova commented Dec 23, 2025

KTOR-9165
KTOR-9193

  • Add documentation for runtime route annotations
  • Update compiler plugin docs for new configuration options
  • add "what's new" sections
  • Add a sample project
  • Remove experimental label
  • update the Swagger UI and OpenAPI plugin topics

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vnikolova vnikolova force-pushed the vnikolova/openapi-spec-gen branch from 3c9da2d to ef10e78 Compare January 7, 2026 10:58
@vnikolova vnikolova marked this pull request as ready for review January 9, 2026 13:13
@vnikolova vnikolova changed the title WIP: Documentation for OpenAPI specification generation KTOR-9165 and KTOR-9193 Documentation for OpenAPI specification generation Jan 9, 2026
@vnikolova vnikolova requested a review from bjhham January 9, 2026 13:14
Comment on lines +67 to +86
}.annotate {
summary = "Get users"
description = "Retrieves a list of users."
parameters {
query("q") {
description = "An encoded query"
required = false
}
}
responses {
HttpStatusCode.OK {
description = "A list of users"
schema = jsonSchema<List<User>>()
}
HttpStatusCode.BadRequest {
description = "Invalid query"
ContentType.Text.Plain()
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to leave a comment here that describes the order of precedence here in building the final model. In this case, we have the comment API and code inference that will supply some of the details, which will merged with the runtime API call from the annotate function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a short paragraph below the example and a new section called "Metadata precedence". Not sure if the placement of it makes sense though and if it's better to place it higher up 🤔

Comment on lines 146 to 160
#### Supported KDoc fields

| Tag | Format | Description |
|-----------------|-------------------------------------------------|----------------------------------|
| `@tag` | `@tag *name` | Groups the endpoint under a tag |
| `@path` | `@path [Type] name description` | Path parameter |
| `@query` | `@query [Type] name description` | Query parameter |
| `@header` | `@header [Type] name description` | Header parameter |
| `@cookie` | `@cookie [Type] name description` | Cookie parameter |
| `@body` | `@body contentType [Type] description` | Request body |
| `@response` | `@response code contentType [Type] description` | Response definition |
| `@deprecated` | `@deprecated reason` | Marks the endpoint as deprecated |
| `@description` | `@description text` | Extended description |
| `@security` | `@security scheme` | Security requirements |
| `@externalDocs` | `@external href` | External documentation link |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 3.4.0, we're updating the comment API style from KDoc tags to use a custom markdown format, due to some concerns over the tags potentially causing some unexpected behaviour in the IDE and KDoc processing. I just changed this last week after some comments from @whyoleg, so it's pretty last-minute 😅

So now all these keywords instead just need to be at the start of the line with a colon divider to designate the value:

/**
 * Get a list of widgets.
 *
 * - Tags:
 *   - widgets
 *   - admin
 * - Cookie: X-Analytics-Session some tracking cookie
 * - Responses:
 *   - 200 application/json [Widget]+ A list of widgets
 *   - 400 Invalid request
 */

Note, the plural form with tags and responses is an optional format, you can also use Tag: widgets, and the list bullets at the top level are also optional and just a matter of preference for formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip. I've updated the section to reflect the changes.

Comment on lines +236 to +240
val docs = generateOpenApiDoc(
OpenApiDoc(info = OpenApiInfo("My API", "1.0")),
apiRoute.descendants()
)
call.respond(docs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that docs is a io.ktor.openapi.OpenApiDoc and the return here is assuming you're using ContentNegotiation with kotlinx-serialization and JSON. Alternatively, you could just use Json.encodeToString(docs) with ContentType.Application.Json here with respondText so it's explicit in how it's serializing the model.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some clarification and a note with an alternative code sample using Json.encodeToString(docs) with ContentType.Application.Json.

Comment on lines 249 to 250
To expose the OpenAPI specification through an interactive UI, use the [OpenAPI](server-openapi.md)
and [SwaggerUI](server-swagger-ui.md) plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have good documentation for the difference between the two plugins. I don't really know the full extent of the differences, but from what I can tell the main difference is that the OpenAPI renders the HTML from the provided model on the back end, and SwaggerUI renders the details from the front end and exposes the model endpoint as JSON or YAML. I would say the Swagger plugin ought to be the default implementation since it's a more modern UI and it's easier to navigate. Maybe @e5l could have some thoughts on this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of bullet points to clarify the difference between the two and updated the plugin topics.


### Runtime route annotations

Ktor 3.4.0 introduces the `ktor-server-routing-annotate` module, which allows you to attach OpenAPI metadata directly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of changing the name of this module before the release to ktor-server-openapi-annotate - I'd originally used routing because I was thinking of a more generic model and only providing the routing function in here, but since then it's become more OpenAPI-specific and provides the means for top-level information as well.

@vnikolova vnikolova force-pushed the vnikolova/openapi-spec-gen branch from c3130ed to 78a1528 Compare January 13, 2026 16:15
@vnikolova vnikolova force-pushed the vnikolova/openapi-spec-gen branch from 397e4a9 to 320c30d Compare January 14, 2026 10:37
@vnikolova vnikolova requested a review from nomisRev January 14, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants