Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply youki to create containers. #168

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

taoohong
Copy link
Contributor

@taoohong taoohong commented Sep 30, 2024

Kuasar can create lightweight Virtual Machine (VMM) type Pods and containers within the virtual machines. Currently, the VMM-task process inside the VM invokes the runc command to create containers, which incurs some performance overhead. Youki containers/youki: A container runtime written in Rust is a container runtime written in Rust and also follows the OCI specification. The goal is to use Youki to improve container creation speed and reduce performance overhead.

vmm-youki

Currently everything is supported except for the stdio without tty, we will submit another PR to fix it after youki-dev/youki#2961 is merged.

@taoohong taoohong requested a review from a team as a code owner September 30, 2024 15:44
@taoohong taoohong marked this pull request as draft September 30, 2024 15:44
@abel-von abel-von marked this pull request as ready for review October 30, 2024 10:09
@abel-von abel-von requested review from a team as code owners October 30, 2024 10:09
@abel-von abel-von force-pushed the apply-youki branch 2 times, most recently from b69cd31 to 925a3ba Compare October 30, 2024 10:20
Vanient and others added 2 commits October 31, 2024 09:23
The issue of the container failing to start through Youki due
due to the improper initialization of socket_path has been resolved.

Signed-off-by: taohong <[email protected]>
@abel-von abel-von force-pushed the apply-youki branch 2 times, most recently from 82013df to 59b1f12 Compare October 31, 2024 01:43
vmm/task/src/youki.rs Show resolved Hide resolved
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some PR description of which funtion is supproted or not, and some functions can be extraed into public one if you have time.

vmm/task/src/youki.rs Show resolved Hide resolved
vmm/task/src/youki.rs Outdated Show resolved Hide resolved
vmm/task/src/youki.rs Show resolved Hide resolved
vmm/task/src/youki.rs Show resolved Hide resolved
vmm/task/src/youki.rs Outdated Show resolved Hide resolved
vmm/task/src/youki.rs Show resolved Hide resolved
vmm/task/src/youki.rs Show resolved Hide resolved
@abel-von
Copy link
Contributor

Please add some PR description of which funtion is supproted or not, and some functions can be extraed into public one if you have time.

Currently everything is supported except for the stdio without tty, we will submit another PR to fix it after youki-dev/youki#2961 is merged.

Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Burning1020 Burning1020 merged commit 056cc28 into kuasar-io:main Oct 31, 2024
18 checks passed
@abel-von
Copy link
Contributor

abel-von commented Nov 7, 2024

close this as #168 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants