Handle empty or invalid training_parameters in HF trainer#2656
Open
Ayush-kathil wants to merge 1 commit intokubeflow:masterfrom
Open
Handle empty or invalid training_parameters in HF trainer#2656Ayush-kathil wants to merge 1 commit intokubeflow:masterfrom
Ayush-kathil wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
harden HuggingFace training_parameters parsing Signed-off-by: Ayush-kathil <kathilshiva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Kubeflow/Katib jobs could pass empty or malformed
training_parameters, causingjson.decoder.JSONDecodeErrorduring HuggingFace trainer startup.Root cause
The example initialized
TrainingArgumentsdirectly fromjson.loads(args.training_parameters)without validating the input shape or handling empty payloads.Fix
Added a dedicated
parse_training_args(raw: str) -> dicthelper, defaulted the CLI argument to "{}", treated empty/None/whitespace as defaultTrainingArguments, logged raw and parsed config safely, and raised clear errors for invalid JSON or malformed keys.Impact
Existing pipelines remain backward compatible, empty payloads now fall back cleanly, and bad configs fail fast with actionable messages instead of an opaque JSON decode crash.
Testing
Added pytest coverage for empty string, None, whitespace, invalid JSON, valid JSON, and malformed keys. Verified with
python -m pytest test_hf_llm_training.py -q.Closes: #2587