-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Chore/drop py39 support #12176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Chore/drop py39 support #12176
Conversation
Hi @aniketpati1121. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
40cdee4
to
b64bda8
Compare
@aniketpati1121 it looks like your rebase with the latest |
b64bda8
to
e934371
Compare
e934371
to
598e5f7
Compare
Hi @mprahl, I have resolved the rebase conflicts and updated the branch. All checks including DCO and CI have passed. The PR is now clean and ready for review. |
Hi, |
2010878
to
12bf84e
Compare
This PR removes unintended test files that were mistakenly included in the previous commits while dropping Python 3.9 support. The history has been cleaned up via rebase to ensure only relevant changes are retained. Changes made: Removed unintended test files (test_kfp_platformspec.py, test_kfp_version.py, and backup .save file). Rebased commits to keep the PR clean and focused. Added Signed-off-by to comply with the DCO requirement. Next steps: Awaiting workflow approval and review from maintainers. |
f56557c
to
2d36eee
Compare
@aniketpati1121, first of all, thanks for the contribution! DCO is still not passing. You can see more details here.
The email you signed the commits with is not the same as the email you signed the DCO with. I'll kick off CI before you fix that. Please make sure to rebase as well. Thanks! |
/ok-to-test |
Approvals successfully granted for pending runs. |
2d36eee
to
cab4f48
Compare
cab4f48
to
6a82cbb
Compare
Signed-off-by: Aniket Patil <[email protected]>
6a82cbb
to
25f8141
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea73267
to
371c4ef
Compare
Signed-off-by: Aniket Patil <[email protected]>
371c4ef
to
60c3482
Compare
Yes, thanks for pointing it out! I’ve updated both kubernetes_platform/python/setup.py and sdk/python/setup.py to drop Python 3.9 and adjust the python_requires field accordingly. The PR now reflects the changes for both the SDK requirements and the CI. |
Thanks, @aniketpati1121 ! Looks like you need to update some of the other workflows as well. |
This PR drops Python 3.9 support in the Kubeflow Pipelines SDK and updates CI workflows
to run tests on Python 3.10. This ensures compatibility with upcoming Python versions
and keeps the SDK dependencies up-to-date.