Skip to content

Conversation

aniketpati1121
Copy link

This PR drops Python 3.9 support in the Kubeflow Pipelines SDK and updates CI workflows
to run tests on Python 3.10. This ensures compatibility with upcoming Python versions
and keeps the SDK dependencies up-to-date.

Copy link

Hi @aniketpati1121. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch 2 times, most recently from 40cdee4 to b64bda8 Compare August 23, 2025 18:15
@google-oss-prow google-oss-prow bot added size/XXL and removed size/M labels Aug 23, 2025
@mprahl
Copy link
Collaborator

mprahl commented Aug 26, 2025

@aniketpati1121 it looks like your rebase with the latest master branch didn't come out cleanly. Could you please fix that so the commits from master aren't in your PR?

@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch from b64bda8 to e934371 Compare August 26, 2025 16:49
@google-oss-prow google-oss-prow bot added size/M and removed size/XXL labels Aug 26, 2025
@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch from e934371 to 598e5f7 Compare August 26, 2025 17:23
@aniketpati1121
Copy link
Author

Hi @mprahl, I have resolved the rebase conflicts and updated the branch. All checks including DCO and CI have passed. The PR is now clean and ready for review.

@aniketpati1121
Copy link
Author

Hi,
I have updated my branch chore/drop-py39-support and resolved all rebase conflicts.
All checks (DCO, CI) have passed.
Could you please review the PR and add /approve and /lgtm so it can be merged?
Thank you!

@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Aug 29, 2025
@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch from 2010878 to 12bf84e Compare August 29, 2025 10:59
@aniketpati1121
Copy link
Author

This PR removes unintended test files that were mistakenly included in the previous commits while dropping Python 3.9 support. The history has been cleaned up via rebase to ensure only relevant changes are retained.

Changes made:

Removed unintended test files (test_kfp_platformspec.py, test_kfp_version.py, and backup .save file).

Rebased commits to keep the PR clean and focused.

Added Signed-off-by to comply with the DCO requirement.

Next steps:

Awaiting workflow approval and review from maintainers.

@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch 5 times, most recently from f56557c to 2d36eee Compare September 2, 2025 17:15
@droctothorpe
Copy link
Collaborator

@aniketpati1121, first of all, thanks for the contribution! DCO is still not passing. You can see more details here.

Commit sha: [6976770](https://github.com/kubeflow/pipelines/pull/12176/commits/6976770b192160eba07879fd5c058a80fc0d1d09), Author: aniketpatil, Committer: aniketpatil; Expected "aniketpatil [[email protected]](mailto:[email protected])", but got "Aniket Patil [[email protected]](mailto:[email protected])".
Commit sha: [2d36eee](https://github.com/kubeflow/pipelines/pull/12176/commits/2d36eeec18b2a3ae6f1719eb682eb5ffb991336c), Author: aniketpatil, Committer: aniketpatil; Expected "aniketpatil [[email protected]](mailto:[email protected])", but got "Aniket Patil [[email protected]](mailto:[email protected])".

The email you signed the commits with is not the same as the email you signed the DCO with.

I'll kick off CI before you fix that. Please make sure to rebase as well. Thanks!

@droctothorpe
Copy link
Collaborator

/ok-to-test

Copy link

github-actions bot commented Sep 2, 2025

Approvals successfully granted for pending runs.

@droctothorpe droctothorpe force-pushed the chore/drop-py39-support branch from 6a82cbb to 25f8141 Compare September 4, 2025 15:16
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Sep 4, 2025
@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch 2 times, most recently from ea73267 to 371c4ef Compare September 4, 2025 17:06
@aniketpati1121 aniketpati1121 force-pushed the chore/drop-py39-support branch from 371c4ef to 60c3482 Compare September 4, 2025 17:09
@aniketpati1121
Copy link
Author

Should we update the SDK reqs as well, not just CI?

Yes, thanks for pointing it out! I’ve updated both kubernetes_platform/python/setup.py and sdk/python/setup.py to drop Python 3.9 and adjust the python_requires field accordingly. The PR now reflects the changes for both the SDK requirements and the CI.

@droctothorpe
Copy link
Collaborator

Thanks, @aniketpati1121 ! Looks like you need to update some of the other workflows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants