Skip to content

Bump Fractions from 7.3.0 to 8.3.2#1736

Merged
k8s-ci-robot merged 3 commits intomasterfrom
dependabot/nuget/Fractions-8.3.2
Apr 30, 2026
Merged

Bump Fractions from 7.3.0 to 8.3.2#1736
k8s-ci-robot merged 3 commits intomasterfrom
dependabot/nuget/Fractions-8.3.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 27, 2026

Updated Fractions from 7.3.0 to 8.3.2.

Release notes

Sourced from Fractions's releases.

No release notes found for this version range.

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: Fractions
  dependency-version: 8.3.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Apr 27, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2026
@brendandburns
Copy link
Copy Markdown
Contributor

@copilot please fix CI/CD

…ints

Fractions 8.x changed behavior so that Fraction.FromString("1.1.") no
longer throws but returns 11/100. Add explicit validation to reject
numeric parts containing more than one decimal point, preserving the
original behavior and fixing QuantityValueTests.Parse CI failure.

Agent-Logs-Url: https://github.com/kubernetes-client/csharp/sessions/b7732b0d-100b-4d92-99bf-354a97c23fc2

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

@copilot please fix CI/CD

Fixed in commit 7297fd4. The CI failure was in QuantityValueTests.Parse — Fractions 8.x changed Fraction.FromString to accept strings with trailing decimal points (e.g., "1.1." now returns 11/100 instead of throwing), so "1.1.M" was no longer rejected as invalid.

Added explicit validation in ResourceQuantity string parsing to throw a FormatException when the numeric part contains more than one decimal point.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • crl.comodoca.com
    • Triggering command: /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/csharp/csharp/src/KubernetesClient.Classic/KubernetesClient.Classic.csproj --packages /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
  • ocsp.comodoca.com
    • Triggering command: /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/csharp/csharp/src/KubernetesClient.Classic/KubernetesClient.Classic.csproj --packages /tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a12d4d5b5555dafc/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

rebase

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@brendandburns
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@k8s-ci-robot k8s-ci-robot merged commit 5fdb99f into master Apr 30, 2026
13 of 14 checks passed
@dependabot dependabot Bot deleted the dependabot/nuget/Fractions-8.3.2 branch April 30, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants