Skip to content

Comments

test: replace mocha with node:test#2340

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:mainfrom
cjihrig:node-test-runner
Mar 31, 2025
Merged

test: replace mocha with node:test#2340
k8s-ci-robot merged 1 commit intokubernetes-client:mainfrom
cjihrig:node-test-runner

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 31, 2025

Fixes #2338

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 31, 2025
@davidgamero
Copy link
Contributor

/lgtm /approve

@brendandburns
Copy link
Contributor

/lgtm
/approve

(they need to be on different lines :))

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 41bbaad into kubernetes-client:main Mar 31, 2025
8 checks passed
@cjihrig cjihrig deleted the node-test-runner branch March 31, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there interest in replacing mocha with node:test

4 participants