Skip to content

WIP: Enable the VolumeGroupSnapshot tests #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Enable the VolumeGroupSnapshot tests #1331

wants to merge 2 commits into from

Conversation

Phaow
Copy link

@Phaow Phaow commented Sep 5, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Enable the VolumeGroupSnapshot tests

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2025
xing-yang
xing-yang reviewed Sep 5, 2025
View reviewed changes
release-tools/prow.sh
@@ -37,6 +37,8 @@
# - kind (https://github.com/kubernetes-sigs/kind) installed
# - optional: Go already installed

set -x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't make changes under release-tools in the sidecar repo directly.

Copy link
Author

@Phaow Phaow Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I am not familiar with this part, so does it mean I need to make changes in https://github.com/kubernetes-csi/csi-release-tools？ Will go through the detail docs, thanks for the info!

xing-yang
xing-yang reviewed Sep 5, 2025
View reviewed changes
pkg/features/features.go Outdated
@@ -39,6 +39,6 @@ func init() {
// defaultKubernetesFeatureGates consists of all known feature keys specific to external-snapshotter.
// To add a new feature, define a key for it above and add it here.
var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
VolumeGroupSnapshot: {Default: false, PreRelease: featuregate.Beta},
VolumeGroupSnapshot: {Default: true, PreRelease: featuregate.Beta},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeGroupSnapshot is still a Beta API. It needs to be false by default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang Thank you for reviewing and look into this! Yeah, I just want to make some hack changes to run the vgs tests, I'll add a new job enbale the feature gate to run vgs tests in presubmit CI after my research. Sorry I forgot to make it as draft.

@Phaow Phaow marked this pull request as draft September 8, 2025 00:41
@Phaow
Copy link
Author

Phaow commented Sep 8, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 8, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 9, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 9, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 9, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 9, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 10, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 10, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 10, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 10, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Phaow
Copy link
Author

Phaow commented Sep 11, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 11, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 11, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 13, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 13, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 13, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 13, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 15, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 15, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 15, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

1 similar comment
@Phaow
Copy link
Author

Phaow commented Sep 15, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 16, 2025 •
edited
Loading

@Phaow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-external-snapshotter-1-31-on-kubernetes-1-31 366ad72 link true /test pull-kubernetes-csi-external-snapshotter-1-31-on-kubernetes-1-31
pull-kubernetes-csi-external-snapshotter-1-32-on-kubernetes-1-32 366ad72 link true /test pull-kubernetes-csi-external-snapshotter-1-32-on-kubernetes-1-32
pull-kubernetes-csi-external-snapshotter-unit 366ad72 link true /test pull-kubernetes-csi-external-snapshotter-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link
Author

Phaow commented Sep 16, 2025

/test pull-kubernetes-csi-external-snapshotter-1-33-on-kubernetes-1-33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phaow @k8s-ci-robot @xing-yang