-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VolumeGroupSnaphot examples #966
Conversation
Signed-off-by: Leonardo Cecchi <[email protected]>
Hi @leonardoce. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is nice to have, will make it much easier for others to try it out, thanks! /lgtm |
/ok-to-test |
/assign xing-yang |
source: | ||
selector: | ||
matchLabels: | ||
app.kubernetes.io/name: postgresql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment here that the PVC will need to have this label for it to be included in the VolumeGroupSnapshot?
Signed-off-by: Leonardo Cecchi <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds two examples of how a VolumeGroupSnapshotClass and a VolumeGroupSnapshot can be defined.
The examples use the CSI Hostpath Driver.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: