Add example for provider specific functions #208
Conversation
k8s-ci-robot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dannawang0221 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
dannawang0221
force-pushed
the
provider-functions-example
branch
from
6cd6067 to
7110644
Compare
|
/assign @sunnylovestiramisu |
| @@ -13,7 +13,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| CMDS_DIR=example | |||
| CMDS=hello-populator | |||
| CMDS ?= hello-populator | |||
There was a problem hiding this comment.
Why do we need to make this change?
There was a problem hiding this comment.
I add a new provider-populator in the example dir. I change it to variable so the users can choose which image to build
| // Implement the provider-specific logic to initiate volume population. | ||
| // This may involve calling cloud-native APIs or creating temporary Kubernetes resources | ||
| // such as Pods or Jobs for data transfer. | ||
| klog.Infof("Run populateFn") |
There was a problem hiding this comment.
This function does not do anything. It would be great to have some logic like what is in the hello populator.
There was a problem hiding this comment.
Hi Xing, what kind of example you are looking for? These functions are for provider specific source and destination storages. Because of the tight connection to the underlying storage, it's tricky to come up with a really generic example that would be helpful.
There was a problem hiding this comment.
Hi Danna,
That's why I'd like to understand how it works. Can you explain what exactly it needs to create and how that is related to the volume populator?
There was a problem hiding this comment.
I add some example steps for each function. Please let me know what do you think.
What type of PR is this?
documentation
What this PR does / why we need it:
Add example for provider specific functions
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: