-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[feat aga] Implement endpoint management for endpoint groups in accelerator #4471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat aga] Implement endpoint management for endpoint groups in accelerator #4471
Conversation
557f5e3 to
06b6baa
Compare
06b6baa to
466d823
Compare
| Namespace: nil, | ||
| Name: nil, | ||
| }, | ||
| gaNamespace: "default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you test w/ a non-default namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, what happens if the namespace is omitted (implicit default)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will always get a namespace from the AGA CRD even if its omitted which defaults to default. It works in that case as well. I have tested it. Is that what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant there should be unit tests that use other namespaces rather than just default.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implements optimized endpoint management for AWS Global Accelerator resources with intelligent handling of endpoint states and API interactions.
Commit 1: [feat aga] Implement endpoints builder filtering for partially loaded…
This change ensures that warning state endpoints don't block the successful deployment of healthy endpoints. While we want to eventually deploy these endpoints when they become healthy, we don't want them to prevent the deployment of already-healthy endpoints.
Commit 2: [feat aga] Implement endpoints deployer with requeue logic for partia…
Implemented comprehensive endpoint drift detection:
Optimized API usage pattern:
Added intelligent error handling with flip-flop pattern:
Implemented warning state requeuing:
Added comprehensive unit tests for all new functionality
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯