feat: rewrite inventory client with basic CRUD #653
Merged
+1,293
−1,988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XXL
sdowell
force-pushed
the
inventory-client-rewrite
branch
2 times, most recently
from
2c4e343 to
f11546a
Compare
|
/ok-to-test I'm sorry, I don't have time to review this atm. |
k8s-ci-robot
added
ok-to-test
sdowell
force-pushed
the
inventory-client-rewrite
branch
2 times, most recently
from
1249b37 to
99285da
Compare
sdowell
force-pushed
the
inventory-client-rewrite
branch
3 times, most recently
from
2f60dad to
a7b18ca
Compare
k8s-ci-robot
added
the
needs-rebase
sdowell
force-pushed
the
inventory-client-rewrite
branch
from
a7b18ca to
7ff6416
Compare
k8s-ci-robot
removed
the
needs-rebase
sdowell
force-pushed
the
inventory-client-rewrite
branch
5 times, most recently
from
8c243ed to
a89d964
Compare
karlkfi
reviewed
Mar 11, 2025
karlkfi
reviewed
Mar 11, 2025
karlkfi
reviewed
Mar 11, 2025
sdowell
force-pushed
the
inventory-client-rewrite
branch
from
64c8ce4 to
fd799fb
Compare
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
karlkfi
reviewed
Mar 19, 2025
sdowell
force-pushed
the
inventory-client-rewrite
branch
3 times, most recently
from
5cf4756 to
2dced84
Compare
karlkfi
reviewed
Mar 19, 2025
sdowell
force-pushed
the
inventory-client-rewrite
branch
from
2dced84 to
fd9949c
Compare
karlkfi
reviewed
Mar 20, 2025
sdowell
force-pushed
the
inventory-client-rewrite
branch
4 times, most recently
from
88118ae to
0832607
Compare
karlkfi
reviewed
Mar 24, 2025
sdowell
force-pushed
the
inventory-client-rewrite
branch
from
0832607 to
4cac084
Compare
This change rewrites the inventory client interface using simple CRUD methods. Prior to this change the inventory client consisted of several tightly coupled interfaces which made the client more complicated and less flexible. The new client interface is simpler to implement and is intended to support implementations for sharded inventories, which may consist of multiple underlying KRM objects. The prior interfaces made assumptions of a single KRM object in several places, which made it incompatible with a sharded inventory.
sdowell
force-pushed
the
inventory-client-rewrite
branch
from
4cac084 to
5d6af3d
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rewrites the inventory client interface using simple CRUD methods. Prior to this change the inventory client consisted of several tightly coupled interfaces which made the client more complicated and less flexible.
The new client interface is simpler to implement and is intended to support implementations for sharded inventories, which may consist of multiple underlying KRM objects. The prior interfaces made assumptions of a single KRM object in several places, which made it incompatible with a sharded inventory.