[WIP] inventory client rewrite #663
Conversation
This change rewrites the inventory client interface using simple CRUD methods. Prior to this change the inventory client consisted of several tightly coupled interfaces which made the client more complicated and less flexible. The old client also performed a Get of the inventory many times throughout the applier/destroyer processes, including before every update. This approach discarded optimistic concurrency protection since the resourceVersion was never persisted. The new approach preserves an internal interface representation of the inventory so that the resourceVersion can be preserved across updates. The new client interface is simpler to implement and is intended to support implementations for sharded inventories, which may consist of multiple underlying KRM objects. The prior interfaces made assumptions of a single KRM object in several places, which made it incompatible with a sharded inventory.
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@karlkfi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.