Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky test] Generate non-overlapping and non-mergable CIDRs with best effort #8587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented Mar 11, 2025

What type of PR is this?

/kind testing

What this PR does / why we need it:

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/8521/pull-cloud-provider-azure-unit-1-31/1897178703616544768

The root cause of the flaky test is that the random fixture occasionally generates overlapping or mergeable CIDRs, which disrupts the comparison and assertions in the test. This PR resolves the issue in the access control flaky test by generating CIDRs with a larger bit size, ensuring that no overlapping CIDRs are produced in a single run—sufficient for the existing test case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/testing release-note-none Denotes a PR that doesn't merit a release note. labels Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zarvd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@nilo19
Copy link
Contributor

nilo19 commented Mar 11, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
@nilo19
Copy link
Contributor

nilo19 commented Mar 11, 2025

do we need to put the flaky one into a for loop to make it run multiple times each time?

@zarvd
Copy link
Contributor Author

zarvd commented Mar 11, 2025

do we need to put the flaky one into a for loop to make it run multiple times each time?

The problem is with the test fixture, not the function itself, so I think we can just skip it.

I also have a pending PR #7190 to merge destination CIDRs, and I might refactor the test fixture in that PR to make it more predictable.

@zarvd zarvd force-pushed the fix/unique-fixture-cidr branch 5 times, most recently from 48c931c to 9985a0e Compare March 12, 2025 04:14
@zarvd zarvd changed the title [flaky test] Generate non-overlapping and non-mergable CIDRs at best effort [flaky test] Generate non-overlapping and non-mergable CIDRs with best effort Mar 12, 2025
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@zarvd zarvd force-pushed the fix/unique-fixture-cidr branch from 9985a0e to e7aa117 Compare March 12, 2025 09:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/testing ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants