-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flaky test] Generate non-overlapping and non-mergable CIDRs with best effort #8587
base: master
Are you sure you want to change the base?
Conversation
Hi @zarvd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
do we need to put the flaky one into a for loop to make it run multiple times each time? |
The problem is with the test fixture, not the function itself, so I think we can just skip it. I also have a pending PR #7190 to merge destination CIDRs, and I might refactor the test fixture in that PR to make it more predictable. |
48c931c
to
9985a0e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, zarvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9985a0e
to
e7aa117
Compare
New changes are detected. LGTM label has been removed. |
What type of PR is this?
/kind testing
What this PR does / why we need it:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/8521/pull-cloud-provider-azure-unit-1-31/1897178703616544768
The root cause of the flaky test is that the random fixture occasionally generates overlapping or mergeable CIDRs, which disrupts the comparison and assertions in the test. This PR resolves the issue in the access control flaky test by generating CIDRs with a larger bit size, ensuring that no overlapping CIDRs are produced in a single run—sufficient for the existing test case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: