Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install description in README.md #209

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update install description in README.md #209

merged 1 commit into from
Feb 5, 2025

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented Feb 5, 2025 •
edited
Loading

Add the macOS brew install method in README.md

I also added some headers that need to be reviewed and fixed.

Fixed #208

Wait for homebrew-core merged: Homebrew/homebrew-core#206262

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@aojea
Copy link
Contributor

aojea commented Feb 5, 2025

awesome, ping when dependencies are merged

BenTheElder
BenTheElder reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, thank you!

README.md Show resolved Hide resolved
@tico88612 tico88612 changed the title [WIP] Update Install description in README.md Update Install description in README.md Feb 5, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@tico88612 tico88612 changed the title Update Install description in README.md Update install description in README.md Feb 5, 2025
@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@BenTheElder
Copy link
Member

/approved
[I see the homebrew PR merged now as well!]

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 76b19a2 into kubernetes-sigs:main Feb 5, 2025
7 checks passed
@tico88612 tico88612 deleted the update/readme-brew branch February 6, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea Awaiting requested review from aojea

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Homebrew installation
4 participants
@tico88612 @aojea @BenTheElder @k8s-ci-robot