-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 🌱Add initial Rosa machine pool integration tests #5214
base: main
Are you sure you want to change the base?
WIP: 🌱Add initial Rosa machine pool integration tests #5214
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @PanSpagetka! |
Hi @PanSpagetka. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9e2fe4e
to
2ce8f3d
Compare
2ce8f3d
to
abce607
Compare
abce607
to
824c0a0
Compare
What type of PR is this?
What this PR does / why we need it:
Adding basic integration tests for
ROSAMachinePoolReconciler
. One test case for creating new machine pool and for deleting.To be able to mock OCM and STS calls I had to do small refactoring.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: