Bump Azure Service Operator from v2.16.0 to v2.17.0#6289
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold until we know for sure how this will affect CAPZ users upgrading |
k8s-ci-robot
added
the
do-not-merge/hold
mboersma
requested review from
jackfrancis,
nojnhuh and
willie-yao
and removed request for
jsturtevant
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
=======================================
Coverage 43.84% 43.84%
=======================================
Files 289 289
Lines 25346 25346
=======================================
Hits 11114 11114
Misses 13458 13458
Partials 774 774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-apiversion-upgrade This one is very flaky, hoping it will improve with the next CAPI patch release. |
|
/retest |
|
/test pull-cluster-api-provider-azure-apiversion-upgrade |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 1f589dddb098e53fcf149eeb522d76a6ee108f31 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/retest |
|
/retest |
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps Azure Service Operator (ASO) from v2.16.0 to v2.17.0.
v2.17.0 picks up microsoft-authentication-library-for-go v1.6.0+, which fixes Azure China Cloud authentication for ASO-managed resources. CAPZ's controller manager already uses the patched MSAL library, but the vendored ASO version did not until now.
Code changes
The only ASO API removed in v2.17.0 that CAPZ depends on is
containerservice/v1api20230315preview. CAPZ uses this forFleetsMember; this PR migrates those imports tocontainerservice/v1api20250301, which is the new GA Fleet API.go.mod/go.sum: ASO v2.16.0 → v2.17.0azure/services/fleetsmembers/*,azure/scope/managedcontrolplane.go,controllers/azuremanagedcontrolplane_controller_test.go,main.go: importv1api20250301instead ofv1api20230315previewforFleetsMemberconfig/aso/kustomization.yaml,config/aso/crds.yaml: regenerated viamake generate-aso-crdsUser upgrade impact
Per the v2.17.0 release notes, the
containerservicev20230315previewFleet CRD versions are removed. Users with existingFleetsMemberresources stored at thev1api20230315previewAPI version need to migrate them tov1api20250301(runningasoctl clean crds) before upgrading to a CAPZ release that includes this change.Upcoming breaking changes (heads up, not in this PR)
containerserviceManagedCluster/AgentPoolAPI versionsv1api20230201andv1api20231001— CAPZ currently usesv1api20231001.v1api20240402preview.Which issue(s) this PR fixes:
Fixes #6275
Special notes for your reviewer:
TODOs:
Release note: