Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] chore: move damdo and salasberryfin to maintainer. #1450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PROPOSAL] chore: move damdo and salasberryfin to maintainer. #1450

wants to merge 1 commit into from
+5 −7

Conversation

richardcase
Copy link
Member

What type of PR is this?
/kind other

What this PR does / why we need it:

Move @damdo and @salasberryfin from reviewer to maintainer.

//cc @cpanato

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This would normally remain open until the next office hours (3rd April). But is Kubecon that week, so unless there are any objections, this will merge on Friday 28th March

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Move @damdo and @salasberryfin from reviewer to maintainer 🎉

@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind other

What this PR does / why we need it:

Move @damdo and @salasberryfin from reviewer to maintainer.

//cc @cpanato

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This would normally remain open until the next office hours (3rd April). But is Kubecon that week, so unless there are any objections, this will merge on Friday 28th March

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Move @damdo and @salasberryfin from reviewer to maintainer 🎉

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from damdo and dims March 19, 2025 14:20
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 20fb6a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/67dbe9c40dd03f0008c449c9
😎 Deploy Preview https://deploy-preview-1450--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richardcase
Copy link
Member Author

/kind chore

@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato
Copy link
Member

cpanato commented Mar 20, 2025

huge +1

cpanato
cpanato reviewed Mar 20, 2025
View reviewed changes
OWNERS_ALIASES
@@ -25,7 +25,8 @@ aliases:
- cpanato
- dims
- richardcase

cluster-api-gcp-reviewers:
- damdo
- salasberryfin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it in alphabetical order?

Copy link
Member Author

@richardcase richardcase Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed so they are in order. I also updated the CAPI admins/maintainers to be current and removed the SIG GCP lead as they haven't been active on GitHub for a very long time.

@richardcase
chore: update maintainer and reviewers
20fb6a3 
Move damdo and salasberryfin from reviewe to maintainer. Also update the
CAPI maintainers/admins. Removed "sig-gcp lead" as they haven't been
active on GitHub since 2017.

Signed-off-by: Richard Case <[email protected]>

stuff

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

@richardcase: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-e2e-test 20fb6a3 link true /test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@damdo damdo Awaiting requested review from damdo

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardcase @k8s-ci-robot @cpanato