Skip to content

Conversation

@arshadd-b
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2025
@arshadd-b arshadd-b changed the title [WIP] Debugging Objects with Changed Resource Versions issue 🌱 [WIP] Debugging Objects with Changed Resource Versions issue Sep 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2025
@arshadd-b
Copy link
Contributor Author

/pull-cluster-api-e2e-blocking-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2025
@arshadd-b arshadd-b changed the title 🌱 [WIP] Debugging Objects with Changed Resource Versions issue 🌱 [WIP] [Do not review] Debugging Objects with Changed Resource Versions issue Sep 25, 2025
@arshadd-b arshadd-b force-pushed the debug-object-version branch 3 times, most recently from b9423a5 to 6af458a Compare September 25, 2025 17:07
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch 2 times, most recently from 5ca9a06 to c9c0bc9 Compare September 26, 2025 11:54
@arshadd-b arshadd-b force-pushed the debug-object-version branch 2 times, most recently from 3b567f0 to 0ee84a4 Compare September 30, 2025 08:34
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch from 0ee84a4 to 4954bad Compare October 6, 2025 13:57
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch 2 times, most recently from 786c137 to 08890d5 Compare October 7, 2025 06:16
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch from c183bf6 to 84daf89 Compare October 17, 2025 15:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2025
@arshadd-b arshadd-b force-pushed the debug-object-version branch from 84daf89 to bf961ec Compare October 17, 2025 15:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2025
@arshadd-b arshadd-b force-pushed the debug-object-version branch 2 times, most recently from e983651 to 170a339 Compare October 18, 2025 05:32
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

1 similar comment
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch from 170a339 to 5b46ddb Compare October 21, 2025 07:34
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

1 similar comment
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@blind3dd
Copy link

blind3dd commented Oct 21, 2025

@arshadd-b I think we are either going to need to adjust the test logic to include internal and externally scoped conversions to have full test suite, ref kubernetes-sigs/controller-runtime#3335, or with dedicated submodule for conversion that is properly scoped and separate, that could make tests suites easier per module with clear separation.
Question is probably of how far are we between internal and external conversion logic and apis versions having in mind cluster-lifecycle and controller-runtime dependency.

@blind3dd
Copy link

blind3dd commented Oct 21, 2025

I do not know how to make a reference to
https://github.com/kubernetes-sigs/cluster-api/pull/12820
and
https://github.com/kubernetes-sigs/controller-runtime/issues/810
and not sure if have rights for doing so.

@arshadd-b arshadd-b force-pushed the debug-object-version branch from 5b46ddb to bd52982 Compare October 22, 2025 02:40
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b arshadd-b force-pushed the debug-object-version branch 3 times, most recently from 66b5822 to e2b01df Compare October 23, 2025 03:31
@arshadd-b arshadd-b force-pushed the debug-object-version branch from e2b01df to b8b7fdb Compare October 23, 2025 06:17
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

6 similar comments
@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@arshadd-b
Copy link
Contributor Author

/test pull-cluster-api-e2e-blocking-main

@k8s-ci-robot
Copy link
Contributor

@arshadd-b: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-blocking-main b8b7fdb link true /test pull-cluster-api-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants