✨ Add lifecycle hooks for chained-upgrade #12878
Open
+2,260
−1,391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
26 tasks
fabriziopandini
force-pushed
the
add-chained-upgrade-lifecyclehooks
branch
2 times, most recently
from
e8af4c6 to
44888d3
Compare
fabriziopandini
commented
Oct 22, 2025
There was a problem hiding this comment.
I'm not sure why diff is so bad 😓
what I did is
- minor adjustments to TestComputeControlPlaneVersion
- drop TestComputeControlPlaneVersion_callAfterControlPlaneUpgrade and TestComputeControlPlaneVersion_callBeforeClusterUpgrade_trackIntentOfCallingAfterClusterUpgrade because they are replaced by the new test in lifecycle_hooks_test.go
fabriziopandini
force-pushed
the
add-chained-upgrade-lifecyclehooks
branch
from
44888d3 to
cae6d82
Compare
|
/test pull-cluster-api-e2e-main |
fabriziopandini
force-pushed
the
add-chained-upgrade-lifecyclehooks
branch
from
cae6d82 to
21b0d44
Compare
|
/test pull-cluster-api-e2e-main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add new lifecycle hooks / change existing hooks as defined by the lifecycle hooks proposal.
Which issue(s) this PR fixes:
Rif #12720