-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow panic as log level #3186
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashmichandrashekar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @rashmichandrashekar! |
Hi @rashmichandrashekar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I am not sure that we want that to be configured to panic but I could be wrong. /hold |
Thanks @troy0820. Its an option that we can leverage while using this module. We have a dependency on an OSS component - opentelemetry-operator from which we utilize some of the features, while it provides a lot more capabilities. Since we are not opting in to all of them, it throws errors which fill up the logs and we would really like to have a way to configure this. |
This allows logging to be disabled for all but panic log entries.
The Zap Level config parameter (https://github.com/uber-go/zap/blob/6d482535bdd97f4d97b2f9573ac308f1cf9b574e/config.go#L62) isn't available via the Option interface, so it's not possible to disable it completely via a user-added flag.