Skip to content

⚠️ Fakeclient: Add apply support (take 2) #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

⚠️ Fakeclient: Add apply support (take 2) #3196

wants to merge 5 commits into from

Conversation

tomasaschan
Copy link
Member

@tomasaschan tomasaschan commented Apr 11, 2025 •
edited
Loading

This is a polish of #2981, which fixes #2341 (and closes #2981 <- noting this explicitly just for the benefit of Github automation).

All I've done is to rebase on latest main to resolve merge conflicts, and address the review feedback from @jpbetz on that PR.

As I have a need for this functionality, and the previous PR was already approved (but not LGTM-ed), I hope that this can be enough to land this functionality in main.

/assign jpbetz

alvaroaleman and others added 3 commits April 11, 2025 09:23
@alvaroaleman @tomasaschan
:warn: Fakeclient: Add apply support
b3f4310 
This change adds apply support into the fake client.

This relies on the upstream support for this which is implemented in a
new [FieldManagedObjectTracker][0]. In order to support many types, a
custom `multiTypeConverter` is added.

[0]: https://github.com/kubernetes/kubernetes/blob/4dc7a48ac6fb631a84e1974772bf7b8fd0bb9c59/staging/src/k8s.io/client-go/testing/fixture.go#L643
@tomasaschan
Address review feedback from kubernetes-sigs#2981
2524cd1
@tomasaschan
Rename import to satisfy linter
1b57de0
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomasaschan
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

@tomasaschan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-test 22440ba link true /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@inteon inteon Awaiting requested review from inteon

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support server-side apply (client.Apply) in fake Client
4 participants
@tomasaschan @k8s-ci-robot @jpbetz @alvaroaleman