Skip to content

🌱chore: Update golangci-lint version to v2.10.1#3470

Open
dongjiang1989 wants to merge 4 commits intokubernetes-sigs:mainfrom
dongjiang1989:update-golangci-linter-version
Open

🌱chore: Update golangci-lint version to v2.10.1#3470
dongjiang1989 wants to merge 4 commits intokubernetes-sigs:mainfrom
dongjiang1989:update-golangci-linter-version

Conversation

@dongjiang1989
Copy link
Member

@dongjiang1989 dongjiang1989 commented Mar 6, 2026

No description provided.

@dongjiang1989
Bump golangci-lint version to v2.10.1
a88da94
@dongjiang1989
fix make lint
e079ff8 
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer March 6, 2026 12:47
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2026
@sbueringer
Copy link
Member

sbueringer commented Mar 6, 2026

Looks like the nolint's are somehow not working, maybe they have to be in different files somehow?

(https://github.com/kubernetes-sigs/controller-runtime/actions/runs/22764085086?pr=3470)

sbueringer
sbueringer reviewed Mar 6, 2026
View reviewed changes
.golangci.yml Outdated
# Allow 'version' as a package name even though it conflicts with Go 1.24+ stdlib
- linters:
- revive
path: tools/setup-envtest/version/.*\.go$
Copy link
Member

@sbueringer sbueringer Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's just use the nolint comments consistently for this one instead of also adding an exclude here?

Copy link
Member Author

@dongjiang1989 dongjiang1989 Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbueringer
Fixed
So many nolint add, just add in .golangci.yml

@dongjiang1989
fix by codereview
306aad4 
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
@dongjiang1989
update fix lint
da12d45 
Signed-off-by: dongjiang <dongjiang2010@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dongjiang1989 @k8s-ci-robot @sbueringer