-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Allow CLI binaries to set a version #1049
🐛 Allow CLI binaries to set a version #1049
Conversation
Signed-off-by: jose.vazquez <[email protected]>
Welcome @josvazg! |
Hi @josvazg. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Please check the CLA |
710ac27
to
53b8fdb
Compare
Last nit from my side, apart from the CLA. I'll test this PR on my fork by cutting a release there |
Co-authored-by: Stefan Büringer <[email protected]>
All good. Here is a test release: https://github.com/sbueringer/controller-tools/releases/tag/v0.16.3-beta.0 Checked the controller-gen-darwin-arm64 binary:
|
/lgtm |
LGTM label has been added. Git tree hash: e21b5f1262222c613e4ae65ac702e640eb641a2b
|
Hopefully the CLA will be sorted out soon now, maybe tomorrow. |
CLA sorted, we can proceed now I guess. |
Nice, thank you! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josvazg, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-tools](https://redirect.github.com/kubernetes-sigs/controller-tools) | `v0.16.2` -> `v0.16.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/sigs.k8s.io%2fcontroller-tools/v0.16.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/sigs.k8s.io%2fcontroller-tools/v0.16.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/sigs.k8s.io%2fcontroller-tools/v0.16.2/v0.16.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/sigs.k8s.io%2fcontroller-tools/v0.16.2/v0.16.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-tools (sigs.k8s.io/controller-tools)</summary> ### [`v0.16.3`](https://redirect.github.com/kubernetes-sigs/controller-tools/releases/tag/v0.16.3) [Compare Source](https://redirect.github.com/kubernetes-sigs/controller-tools/compare/v0.16.2...v0.16.3) Published binaries on previous v0.16.x releases were reporting an incorrect version. #### What's Changed - 🐛 Allow CLI binaries to set a version by [@​josvazg](https://redirect.github.com/josvazg) in [https://github.com/kubernetes-sigs/controller-tools/pull/1049](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1049) - ✨ Allow customizing generated webhook configuration's name by [@​davidxia](https://redirect.github.com/davidxia) in [https://github.com/kubernetes-sigs/controller-tools/pull/1002](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1002) #### Dependencies - 🌱 Bump github.com/onsi/gomega from 1.34.1 to 1.34.2 in the all-go-mod-patch-and-minor group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/kubernetes-sigs/controller-tools/pull/1047](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1047) - 🌱 Bump tj-actions/changed-files from 45.0.0 to 45.0.1 in the all-github-actions group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/kubernetes-sigs/controller-tools/pull/1048](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1048) - 🌱 Bump peter-evans/create-pull-request from 6.1.0 to 7.0.1 in the all-github-actions group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/kubernetes-sigs/controller-tools/pull/1052](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1052) #### New Contributors - [@​josvazg](https://redirect.github.com/josvazg) made their first contribution in [https://github.com/kubernetes-sigs/controller-tools/pull/1049](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1049) - [@​davidxia](https://redirect.github.com/davidxia) made their first contribution in [https://github.com/kubernetes-sigs/controller-tools/pull/1002](https://redirect.github.com/kubernetes-sigs/controller-tools/pull/1002) **Full Changelog**: kubernetes-sigs/controller-tools@v0.16.2...v0.16.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/registry-operator/registry-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXJlYS9kZXBlbmRlbmN5Il19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Solves #1046 so that
controller-gen
binaries can show a proper versionLocal testing:
% go build -ldflags "-X sigs.k8s.io/controller-tools/pkg/version.version=1.2.4" ./cmd/controller-gen % ./controller-gen --version Version: 1.2.4