Skip to content

🌱 Add tests to improve coverage for IntOrStringWithEnumSlice#1385

Open
dongjiang1989 wants to merge 2 commits into
kubernetes-sigs:mainfrom
dongjiang1989:update-enum
Open

🌱 Add tests to improve coverage for IntOrStringWithEnumSlice#1385
dongjiang1989 wants to merge 2 commits into
kubernetes-sigs:mainfrom
dongjiang1989:update-enum

Conversation

@dongjiang1989
Copy link
Copy Markdown
Member

@dongjiang1989 dongjiang1989 commented Apr 21, 2026

This is the next pr for #1370

Signed-off-by: dongjiang <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2026
Signed-off-by: dongjiang <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2026
Comment thread pkg/crd/testdata/cronjob_types.go
@dongjiang1989 dongjiang1989 changed the title 🌱 Add enum validation support for IntOrString slice items case ✨Add enum validation support for IntOrString slice items case Apr 21, 2026
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit in the emoji should be 🌱

Otherwise, it seems solid.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86, dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fd58d71f209290542107a2564081f53a9484d069

@dongjiang1989 dongjiang1989 changed the title ✨Add enum validation support for IntOrString slice items case 🌱 Add tests to improve coverage for IntOrStringWithEnumSlice Apr 21, 2026
@dongjiang1989
Copy link
Copy Markdown
Member Author

cc @sbueringer PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants