Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update to k8s v0.32.0 and runtime to v0.20.0 (#226)" #243

Closed
wants to merge 1 commit into from

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Jan 29, 2025

This reverts commit fbe77dd.

Had to revert this as this breaks the EPP. The predicates seem to be causing the endpointslice reconciler to never reconcile. Reverting for now to get back to healthy. We can choose to investigate or wait for a later patch that might have stability (potential issues with a new Minor Rev of controller runtime?)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4a0c09c
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67997bdb7b21010008f33f79
😎 Deploy Preview https://deploy-preview-243--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

@kfswain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-verify-main 4a0c09c link true /test pull-gateway-api-inference-extension-verify-main
pull-gateway-api-inference-extension-test-unit-main 4a0c09c link true /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 29, 2025

This is not the bug, the issue is that the endpointslice was not being reconciled. One theory is that we don't force a sync at epp startup, and so we miss reconciling the endpointslice if the model service was created before the epp, which is the case in our example.

@danehans
Copy link
Contributor

The predicates seem to be causing the endpointslice reconciler to never reconcile.

This is a known issue that I captured in #174.

@kfswain kfswain closed this Jan 29, 2025
@kfswain kfswain deleted the epp-fix branch February 10, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants