-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update to k8s v0.32.0 and runtime to v0.20.0 (#226)" #243
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kfswain: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is not the bug, the issue is that the endpointslice was not being reconciled. One theory is that we don't force a sync at epp startup, and so we miss reconciling the endpointslice if the model service was created before the epp, which is the case in our example. |
This is a known issue that I captured in #174. |
This reverts commit fbe77dd.
Had to revert this as this breaks the EPP. The predicates seem to be causing the endpointslice reconciler to never reconcile. Reverting for now to get back to healthy. We can choose to investigate or wait for a later patch that might have stability (potential issues with a new Minor Rev of controller runtime?)