Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gep 2907 update - TLS mode and allowed routes #3458

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Gep 2907 update - TLS mode and allowed routes #3458

wants to merge 4 commits into from
+75 −7

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Nov 19, 2024 •
edited
Loading

What type of PR is this?

/kind gep

What this PR does / why we need it:

This PR supersedes #3190.

This PR updates GEP-2907 with two different aspects:

  • definition of TLS mode (Terminate and Passthrough)
  • what routes can be attached to Listeners that specify TLS configuration.

This PR intends to reach an agreement that will make #2111 and #1474 addressable.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
@mlavacca
Copy link
Member Author

/cc @candita @youngnick

@youngnick
Copy link
Contributor

youngnick commented Nov 21, 2024 •
edited
Loading

Yeah, this accurately conveys the current state, although I think that we do not have any conformance testing at all about TLSRoute with Terminate behavior.

Edit LGTM, but I'd like to hear from others too.

@mlavacca mlavacca mentioned this pull request Nov 21, 2024
Open
@mlavacca
Copy link
Member Author

Yeah, this accurately conveys the current state, although I think that we do not have any conformance testing at all about TLSRoute with Terminate behavior.

Edit LGTM, but I'd like to hear from others too.

Yep, I just created #3466 to track conformance tests with TLSRoutes in Terminate Mode.

@mlavacca
Copy link
Member Author

/cc @robscott @shaneutt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt requested review from kflynn, gcs278 and arkodg January 23, 2025 13:45
robscott
robscott reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlavacca! Sorry I missed this one!

geps/gep-2907/index.md Outdated Show resolved Hide resolved
geps/gep-2907/index.md Outdated Show resolved Hide resolved
keithmattix
keithmattix reviewed Jan 28, 2025
View reviewed changes
geps/gep-2907/index.md Outdated Show resolved Hide resolved
geps/gep-2907/index.md Outdated Show resolved Hide resolved
mikemorris
mikemorris reviewed Jan 30, 2025
View reviewed changes
geps/gep-2907/index.md Outdated Show resolved Hide resolved
mlavacca and others added 4 commits February 3, 2025 19:33
@mlavacca
gep: TLS mode in gep-2907
f38ac1d 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca
add note on TCPRoute
4ff9a95 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca @keithmattix @mikemorris
Apply suggestions from code review
5ccfb06 
Co-authored-by: Keith Mattix II <[email protected]>
Co-authored-by: Mike Morris <[email protected]>
@mlavacca
geps: improve route/tls-mode table
358b483 
The table related to protocol-supported routes-TLS mode has been
improved to address reviews' comments.

Signed-off-by: Mattia Lavacca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@candita candita Awaiting requested review from candita

@youngnick youngnick Awaiting requested review from youngnick

@kflynn kflynn Awaiting requested review from kflynn

@gcs278 gcs278 Awaiting requested review from gcs278

@arkodg arkodg Awaiting requested review from arkodg

@keithmattix keithmattix Awaiting requested review from keithmattix

@mikemorris mikemorris Awaiting requested review from mikemorris

@howardjohn howardjohn Awaiting requested review from howardjohn

@robscott robscott Awaiting requested review from robscott

@webwurst webwurst Awaiting requested review from webwurst

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mlavacca @youngnick @k8s-ci-robot @webwurst @robscott @howardjohn @mikemorris @keithmattix @shaneutt