-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert E2E tests to running the PD CSI driver in a container instead of a binary directly #1900
base: master
Are you sure you want to change the base?
Conversation
the previous errors from being shadowed.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tonyzhc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @tonyzhc! |
Hi @tonyzhc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
It converts the test code from running the PD CSI driver as a binary on GCE to running it as a container image. This increases test coverage to include our Dockerfile and its dependencies.
Which issue(s) this PR fixes:
Fixes b/261474293
Special notes for your reviewer:
Does this PR introduce a user-facing change?: