-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax volumeContentSource restriction for ROX multi-zone dynamic volume creation #1975
base: master
Are you sure you want to change the base?
Relax volumeContentSource restriction for ROX multi-zone dynamic volume creation #1975
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
…me creation. This enables empty ROX multi-zone PVCs to be created, to allow for static hydration of disks
ef7ea41
to
7f86194
Compare
@pwschuurman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This enables empty ROX multi-zone PVCs to be created, to allow for static hydration of disks
What type of PR is this?
What this PR does / why we need it: Currently ROX multi-zone volumes can only be created from a volume source (eg: snapshot/disk image). This limits the flexibility of a user that wants to create a ROX multi-zone volume which is empty, and then write the same data individually to each created disk. This allows all disks to share the same name (as they are part of a "multi-zone" volume), but have data populated without needing to pre-create a snapshot/disk image (as copying data directly to each individual disk in parallel can be faster than creating and restoring from a snapshot).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: