Introduce Disk Topology Feature

[julianKatz]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

This PR introduces a new, flag-gated feature: Disk Topology. Disk Topology has two fundamental pieces:

1. More labels in NodeGetInfo

   Historically, only the topology.gke.io/zone label would be returned as a Topology in NodeGetInfo. GKE will be implementing a host of new labels that are 1:1 with each of its disk products (both legacy Persistent Disk and new Hyperdisk products). This PR adds support for those labels in NodeGetInfo.

2. Adding a disk type label in CreateVolumeResponse.Topologies based on parameters.type

   With the addition of these new disk type labels to nodes, we can include disk type labels in workload scheduling. To affect that, those same labels must be included in a PersistentVolume's NodeAffinity clause. This PR includes a disk support label consistent with the type specified in the StorageClass in each of the Topology segments included in CreateVolumeResponse. External Provisioner will then read these and add them as NodeAffinity requirements on the PV.

The feature is gated on the newly introduced --disk-topology=[true|false] flag, which is disabled by default.

Special notes for your reviewer: None.

Does this PR introduce a user-facing change?:

Yes, users can set the flag to true and enable the new functionality.

Added disk topology feature, enabled using --disk-topology=true (default off).  Disk topology includes support for `topology.gke.io/[disk-type]: true` labels on nodes and adds a label in that format to each CreateVolumeRequest.Volume.AccessibleTopology segment, which equate to NodeAffinity blocks in the eventual Persistent Volume.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julianKatz
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @julianKatz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hungnguyen243]

/ok-to-test

[sunnylovestiramisu]

/ok-to-test

[julianKatz]

/test all

[julianKatz]

/retest

[mattcary]

basically looks like the right direction.

you may have to do something to make sure the e2e tests work correctly -- I'm not sure what the did there for datacache.

[julianKatz]

/retest

[k8s-ci-robot]

@julianKatz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022	11bf338	link	false	/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration	11bf338	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019	11bf338	link	false	/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.