-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minCpuPlatform check when re-creating e2e test intsances #2005
base: master
Are you sure you want to change the base?
Update minCpuPlatform check when re-creating e2e test intsances #2005
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @cemakd |
@pwschuurman: GitHub didn't allow me to request PR reviews from the following users: cemakd. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @cemakd |
@pwschuurman: GitHub didn't allow me to assign the following users: cemakd. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
74069dd
to
575c25a
Compare
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
4 similar comments
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
@pwschuurman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
What type of PR is this?
What this PR does / why we need it:
This fixes an issue where subsequent e2e test runs delete and re-create instances, due to
minCpuPlatform
string mismatchWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: