-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump csi proxy client version to 1.2.1 #2024
Bump csi proxy client version to 1.2.1 #2024
Conversation
Hi @hajiler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hajiler, sunnylovestiramisu, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this PR won't change the flakiness given that the change that we want kubernetes-csi/csi-proxy#364 is part of the server side component, not the client side which is what this PR is changing. The server side version is changed in the k/k codebase, let's wait for kubernetes/kubernetes#131146 to be merged and see https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#ci-windows-2019-provider-gcp-compute-persistent-disk-csi-driver for results post-merge. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Bumps csi proxy client version to 1.2.1. This will address flakiness in our windows testing.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: