refactor, add xtables.ExecWrapper - #18
Merged
Merged
Conversation
kubernetes-prow
Bot
added
do-not-merge/hold
kubernetes-prow
Bot
added
cncf-cla: yes
danwinship
force-pushed
the
refactor
branch
from
September 18, 2026 19:57
59dc8a1 to
88605d6
Compare
Contributor
Author
|
/hold cancel |
kubernetes-prow
Bot
removed
the
do-not-merge/hold
Contributor
Author
|
(running apidiff for informational purposes but it's intentionally non-required) |
aojea
reviewed
Sep 19, 2026
Comment on lines
-38
to
-39
| xtablesLegacyMultiBinaryName = "xtables-legacy-multi" | ||
| xtablesNFTMultiBinaryName = "xtables-nft-multi" |
Contributor
There was a problem hiding this comment.
yeah, this was always surprising my why we depend on those
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the
DetectModecode and adds the newxtables.ExecWrapper, to (eventually) allow wrapping utiliptables with automatic legacy/nft detection/hold
want to make sure CI runs as expected