-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect /etc/containerd/certs.d automatically for mirror registry config. #3574
base: main
Are you sure you want to change the base?
Detect /etc/containerd/certs.d automatically for mirror registry config. #3574
Conversation
This will allow a slightly smoother transition for people who wish to already move to the new non deprecated way to configure registries in containerd and who build their own node image (or bind mount the config). Eventually since the old way won't work, this should be the default configuration, written directly in the config.toml main file. Signed-off-by: Romain Geissler <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Romain-Geissler-1A The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Romain-Geissler-1A! |
Hi @Romain-Geissler-1A. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -145,6 +145,12 @@ configure_containerd() { | |||
systemctl enable containerd-fuse-overlayfs | |||
fi | |||
fi | |||
|
|||
if [[ -e "/etc/containerd/certs.d" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still technically a breaking change because the user could've been using this directory with the old config approach.
I'm not sure this is better than just announcing that we've changed the config and we've already encouraged users customizing the config to switch and updated our registry sample script to switch.
This will allow a slightly smoother transition for people who wish to already move to the new non deprecated way to configure registries in containerd and who build their own node image (or bind mount the config).
Eventually since the old way won't work, this should be the default configuration, written directly in the config.toml main file.