-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the default hostIP for get kubeconfig
#3778
Conversation
Welcome @kebe7jun! |
Hi @kebe7jun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
see if this #3777 is happening with latest version of kind, there were multiple fixes since then , specially for podman that broke compatibility with portmaps some time ago |
/ok-to-test One suggestion so we understand why we are doing this so we don't have to remember :) |
/test pull-kind-verify |
@aojea Would you please help me figure out why this test( |
@kebe7jun please squash all the commits |
500ed8b
to
65afa77
Compare
Update pkg/cluster/internal/providers/podman/provider.go Co-authored-by: Antonio Ojea <[email protected]>
65afa77
to
1852589
Compare
/lgtm let's go with 127.0.0.1 , |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, kebe7jun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #3777