Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the default hostIP for get kubeconfig #3778

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kebe7jun
Copy link
Contributor

@kebe7jun kebe7jun commented Nov 6, 2024

Fix #3777

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/podman Issues or PRs related to podman labels Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @kebe7jun!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kebe7jun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2024
@aojea
Copy link
Contributor

aojea commented Nov 6, 2024

see if this #3777 is happening with latest version of kind, there were multiple fixes since then , specially for podman that broke compatibility with portmaps some time ago

@aojea
Copy link
Contributor

aojea commented Nov 7, 2024

/ok-to-test

One suggestion so we understand why we are doing this so we don't have to remember :)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2024
@kebe7jun
Copy link
Contributor Author

kebe7jun commented Nov 7, 2024

/test pull-kind-verify

@kebe7jun
Copy link
Contributor Author

kebe7jun commented Nov 7, 2024

@aojea Would you please help me figure out why this test(pull-kind-verify ) fails? I executed make verify locally and it was successful. Sorry for not knowing much about kind testing.

@aojea
Copy link
Contributor

aojea commented Nov 7, 2024

@kebe7jun please squash all the commits

Update pkg/cluster/internal/providers/podman/provider.go

Co-authored-by: Antonio Ojea <[email protected]>
@aojea
Copy link
Contributor

aojea commented Nov 7, 2024

/lgtm
/approve

let's go with 127.0.0.1 ,

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, kebe7jun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 30bc6ab into kubernetes-sigs:main Nov 7, 2024
17 checks passed
@kebe7jun kebe7jun deleted the fix/default-hostip branch November 8, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/podman Issues or PRs related to podman cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using podman, the configuration obtained using get kubeconfig cannot be used
4 participants