🌱 (chore): unify init and edit subcommands into a single command struct

[kersten]

• Replaces separate init/edit subcommands with a shared subcommand type
• Uses dynamic scaffolder injection for each command
• Adds suite and plugin tests for Grafana plugin

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kersten
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @kersten. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @kersten 👋

Thanks so much for taking the time to look into this one — really appreciate your work here! 🎉

That said, I don’t think we need to introduce a new structure for this.

The init and edit commands should still go through the existing scaffolded interfaces. This helps ensure that descriptions, example snippets, and the UI behave consistently for both commands.

I believe we can follow the same pattern we used for the HelmPlugin:
https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/optional/helm/v1alpha

In that case, the edit command simply calls into the same internal logic used by init, since they perform the same scaffolding work. For reference:

kubebuilder/pkg/plugins/optional/helm/v1alpha/edit.go

Lines 76 to 86 in 258b9c6

	func (p *editSubcommand) Scaffold(fs machinery.Filesystem) error {
	scaffolder := scaffolds.NewInitHelmScaffolder(p.config, p.force)
	scaffolder.InjectFS(fs)
	err := scaffolder.Scaffold()
	if err != nil {
	return fmt.Errorf("error scaffolding Helm chart: %w", err)
	}
	// Track the resources following a declarative approach
	return insertPluginMetaToConfig(p.config, pluginConfig{})
	}

It keeps the code DRY and easier to maintain while still providing a great user experience across both commands.

See:

Thanks again — looking forward to your thoughts! 🙌

[camilamacedo86]

Do we need this change to achieve the intended goal?

If not, what do you think about starting with a PR that increases the Grafana plugin test coverage first? That way, we can define a clearer scope and build on top of that with more confidence.

Let me know your thoughts! 😊

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.