🐛 fix(helm/v2-alpha): correct indentation of conditional volume mounts#5678
Conversation
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @felix-kaestner. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
The conditional wrappers for webhook-certs and metrics-certs volumes/volumeMounts were placed at the same indent level as the parent key. This caused a YAML parse error when extraVolumeMounts or extraVolumes were populated, since those template directives were at child indent (key + 2 spaces), resulting in mixed indent levels within the same YAML list. Shift the conditional blocks by 2 additional spaces so that items align with the child indent used by appendToListFromValues.
| - mountPath: /tmp/k8s-webhook-server/serving-certs | ||
| name: webhook-certs | ||
| readOnly: true | ||
| {{- end }} |
There was a problem hiding this comment.
We have a check to avoid it.
See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/Makefile#L125-L129
And: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/verify-all.yml#L113-L134
So, I think we need to use this one to fix the check.
It should be falling.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
camilamacedo86
changed the title
|
Hey @camilamacedo86, could the failing e2e job for k8s 1.36 be related to #5667? I see this job also failing on other PRs, so I think it might not be related to my changes. |
Yes, we need wait release of an Kind image that suppports 1.36 to fix that |
|
/override pull-kubebuilder-e2e-k8s-1-36-0 |
|
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-36-0 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, felix-kaestner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/override pull-kubebuilder-e2e-k8s-1-36-0 |
|
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-36-0 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The conditional wrappers for webhook-certs and metrics-certs volumes/volumeMounts were placed at the same indent level as the parent key. This caused a YAML parse error when extraVolumeMounts or extraVolumes were populated, since those template directives were at child indent (key + 2 spaces), resulting in mixed indent levels within the same YAML list.
Shift the conditional blocks by 2 additional spaces so that items align with the child indent used by appendToListFromValues.
See #5677.