Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update failure injection demos #1184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update failure injection demos #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions demo/container-failure.demo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
# Create a cluster with kwok
kwokctl create cluster --enable-crds Stage

# Apply stage files
kubectl apply -f https://github.com/kubernetes-sigs/kwok/releases/download/v0.5.2/stage-fast.yaml
# Deploy kwok crds and stage files
kubectl apply -f https://github.com/kubernetes-sigs/kwok/releases/download/v0.6.0/kwok.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cluster is created by kwokctl, that don't need this kwok

#kubectl apply -f https://github.com/kubernetes-sigs/kwok/releases/download/v0.6.0/stage-fast.yaml
kubectl apply -f https://github.com/kubernetes-sigs/kwok/raw/main/kustomize/stage/pod/chaos/pod-container-running-failed.yaml
kubectl get stages

Expand Down
2 changes: 1 addition & 1 deletion demo/container-failure.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This demo seems to be failure, it need to regenerate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error in the stage file. Can you take a look? @wzshiming

~/sigs.k8s.io/kwok$ kubectl apply -f https://github.com/kubernetes-sigs/kwok/raw/main/kustomize/stage/pod/chaos/pod-container-running-failed.yaml
Error from server (BadRequest): error when creating "https://github.com/kubernetes-sigs/kwok/raw/main/kustomize/stage/pod/chaos/pod-container-running-failed.yaml": Stage in version "v1alpha1" cannot be handled as a Stage: strict decoding error: unknown field "spec.weightFrom"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weightFrom is a new field in Stage, released in 0.6, you may need to upgrade the kwokctl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it and regenerated the demo.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions site/content/en/docs/user/examples/injectfailure/failed-pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ metadata:
pod-init-container-running-failed.stage.kwok.x-k8s.io/reason: nccl-test-failed
pod-init-container-running-failed.stage.kwok.x-k8s.io/message: "nccl test failed"
pod-init-container-running-failed.stage.kwok.x-k8s.io/exit-code: "3"
pod-init-container-running-failed.stage.kwok.x-k8s.io/delay: "1000"
pod-init-container-running-failed.stage.kwok.x-k8s.io/jitter-delay: "5000"
pod-init-container-running-failed.stage.kwok.x-k8s.io/delay: "5s"
pod-init-container-running-failed.stage.kwok.x-k8s.io/jitter-delay: "5s"
spec:
affinity:
nodeAffinity:
Expand Down
Loading
Loading