Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypickapproved: implement org-level configuration #232

Closed

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 16, 2024

This PR implements the org-level configuration for the cherrypickapproved plugin. Right now, it's possible to configure this plugin only on the repo-level. If you have multiple repos, you have to repeat the config for each repo, which is inefficient and clutters the configuration file, especially if the config is the same for all repos.

With this PR, such a configuration is allowed:

cherry_pick_approved:
  - org: org-name
    branchregexp: '^release/v.*$'
    approvers:
      - ...

The repo-level config has the priority over the org level configuration. This also means that this is not a breaking change, i.e. the existing configurations will continue working as before.

/assign @saschagrunert
cc @kubernetes-sigs/release-engineering

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2024
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit ed8a5a0
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66bf40069eef93000887ad83
😎 Deploy Preview https://deploy-preview-232--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xmudrii xmudrii force-pushed the cherrypickapproved-org-level branch from 283ba93 to ed8a5a0 Compare August 16, 2024 12:03
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2024

/test pull-prow-unit-test-race-detector-nonblocking

@matthyx
Copy link
Contributor

matthyx commented Aug 16, 2024

@xmudrii you might want to take a look at #147 where I'm trying to propose a generic solution that could be applied to all plugins

@xmudrii
Copy link
Member Author

xmudrii commented Aug 27, 2024

In addition to #147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed.
/close

@k8s-ci-robot
Copy link
Contributor

@xmudrii: Closed this PR.

In response to this:

In addition to #147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii xmudrii deleted the cherrypickapproved-org-level branch August 27, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants