Skip to content

Detect historical flakes in passing TestGrid tabs - #122

Open
SaaiAravindhRaja wants to merge 1 commit into
kubernetes-sigs:mainfrom
SaaiAravindhRaja:fix/historical-flake-detection
Open

SaaiAravindhRaja wants to merge 1 commit into
kubernetes-sigs:mainfrom
SaaiAravindhRaja:fix/historical-flake-detection

Conversation

@SaaiAravindhRaja

@SaaiAravindhRaja SaaiAravindhRaja commented Aug 9, 2026

Copy link
Copy Markdown

Fixes #22

Signalhound currently skips table data for tabs whose TestGrid summary has returned to passing. That hides failures still present in the tab history, which is common for hourly jobs after a short run of successful builds.

This change also inspects passing tabs and reports them as flaky only when their table history contains actual failure statuses. Table requests are bounded so the additional lookups do not run serially or without a limit.

Verification

  • make test
  • go test -race ./internal/testgrid ./cmd

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaaiAravindhRaja
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from jrsapi August 9, 2026 15:22
@kubernetes-prow kubernetes-prow Bot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Aug 9, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from salaxander August 9, 2026 15:22
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @SaaiAravindhRaja!

It looks like this is your first PR to kubernetes-sigs/signalhound 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/signalhound has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fails to detect active flakes in hourly jobs if no flake occurred in the past ~9 hours

1 participant