Fix make lint install path - #123
Open
stmcginnis wants to merge 1 commit into
Open
stmcginnis wants to merge 1 commit into
stmcginnis wants to merge 1 commit into
Conversation
When we moved to golangci-lint v2, the `go install` path changed to point to the v2 module path. This worked fine in CI since the golangci-lint action automatically takes care of it based on the configured version. But attempting to run `make install` on a machine that doesn't already have the binary results in a failure. This updates the defaulted path for the linter to be the correct current v2 path. Also bumps up to the next point release while we're at it. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
sig/release
kubernetes-prow
Bot
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we moved to golangci-lint v2, the
go installpath changed to point to the v2 module path. This worked fine in CI since the golangci-lint action automatically takes care of it based on the configured version. But attempting to runmake installon a machine that doesn't already have the binary results in a failure.This updates the defaulted path for the linter to be the correct current v2 path.
Also bumps up to the next point release while we're at it.