-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vpa): update api-docs script #7985
chore(vpa): update api-docs script #7985
Conversation
missed some exports to work correctly.
Hi @toredash. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @adrianmoisey since he is the one who added this. |
/assign adrianmoisey |
Thanks! That seems to be something I missed. Approving now since it's not directly VPA related |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, toredash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR updates the generate-api-docs script for VPA.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Executing the generate scripts locally fails as the reference to crd-ref-docs is not provided in the script
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?