Skip to content

chore: use maintained version of misspell #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iamzili wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: use maintained version of misspell #8930

iamzili wants to merge 2 commits into from
+14 −2

Conversation

@iamzili
Copy link
Member

@iamzili iamzili commented Dec 12, 2025 •
edited by jackfrancis
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Just a small cleanup to use the maintained version of misspell, the K8s repo has already transitioned to this version.

client9/misspell#197 (comment)

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 12, 2025

Hi @iamzili. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2025
@jackfrancis
Copy link
Contributor

jackfrancis commented Dec 12, 2025

@iamzili would you be willing to address the beneficial outcomes of this change? :)

Error: cluster-autoscaler/cloudprovider/civo/civo_node_group.go:133:19: "deleteing" is a misspelling of "deleting"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/autoscaling/service_autoscaling.go:51:55: "identifer" is a misspelling of "identifier"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/ecs/service_ecs.go:51:52: "identifer" is a misspelling of "identifier"

(The SDK files may be copy/paste vendored code, so we may just need to add that directory to an ignore config)

@jackfrancis
Copy link
Contributor

jackfrancis commented Dec 12, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 12, 2025
jackfrancis
jackfrancis requested changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't land this until we fix the spelling errors:

Error: cluster-autoscaler/cloudprovider/civo/civo_node_group.go:133:19: "deleteing" is a misspelling of "deleting"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/autoscaling/service_autoscaling.go:51:55: "identifer" is a misspelling of "identifier"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/ecs/service_ecs.go:51:52: "identifer" is a misspelling of "identifier"

@adrianmoisey
Copy link
Member

adrianmoisey commented Dec 13, 2025

cluster-autoscaler/cloudprovider/civo/civo_node_group.go

All three of these are from vendored upstream libraries. Fixing them in this repo seems wrong.
My vote is to exclude these

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-area size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2025
@iamzili
Copy link
Member Author

iamzili commented Dec 16, 2025

All three of these are from vendored upstream libraries. Fixing them in this repo seems wrong. My vote is to exclude these

I agree with you, but after upgrading misspell, new misspellings were identified, so I just fixed them quickly.

@iamzili
Copy link
Member Author

iamzili commented Dec 16, 2025

We can't land this until we fix the spelling errors:

Error: cluster-autoscaler/cloudprovider/civo/civo_node_group.go:133:19: "deleteing" is a misspelling of "deleting"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/autoscaling/service_autoscaling.go:51:55: "identifer" is a misspelling of "identifier"
Error: cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk/service/ecs/service_ecs.go:51:52: "identifer" is a misspelling of "identifier"

fixed :)

jackfrancis
jackfrancis requested changes Dec 18, 2025
View reviewed changes
...scaler/cloudprovider/volcengine/volcengine-go-sdk/service/autoscaling/service_autoscaling.go Outdated
ServiceName = "autoscaling" // Name of service.
EndpointsID = ServiceName // ID to lookup a service endpoint with.
ServiceID = "auto_scaling" // ServiceID is a unique identifer of a specific service.
ServiceID = "auto_scaling" // ServiceID is a unique identifier of a specific service.
Copy link
Contributor

@jackfrancis jackfrancis Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @adrianmoisey, we should not change this vendored code in (sorry if I sent you on a side quest). We should be able to get the CI to pass if we revert these two changes to cluster-autoscaler/cloudprovider/volcengine/volcengine-go-sdk, and then add that directory to the set of grep -v directories in hack/verify-spelling.sh

Copy link
Member Author

@iamzili iamzili Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, fixed :) now hack/verify-spelling.sh doesn't complain

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamzili
Once this PR has been reviewed and has the lgtm label, please assign kgolab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2025
@iamzili
Copy link
Member Author

iamzili commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamzili Once this PR has been reviewed and has the lgtm label, please assign kgolab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:

* **[hack/OWNERS](https://github.com/kubernetes/autoscaler/blob/master/hack/OWNERS)**

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

hm, I didn't approve it :D

@adrianmoisey
Copy link
Member

adrianmoisey commented Dec 19, 2025

/lgtm
Thanks!

I believe authors auto-approve their own PRs in Kubernetes repos

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis requested changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@kgolab kgolab Awaiting requested review from kgolab

Assignees

@adrianmoisey adrianmoisey

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamzili @k8s-ci-robot @jackfrancis @adrianmoisey