Skip to content

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #8963

/assign jackfrancis

Add new label to last_activity metric called "mainSuccessful" that is emitted after each full loop execution that finishes without errors.

…toscaler.

This will allow to detect situations where loop starts and not ends (because of a health check for example).

Note that existing loop start metric is not enough because if we have
autoscaler killed another autoscaler will take over role of the leader
and again emit the metric of the main starting.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area labels Dec 19, 2025
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1722001 into kubernetes:cluster-autoscaler-release-1.35 Dec 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants