Skip to content

KEP-4192: Update beta requirements #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-4192: Update beta requirements #5472

wants to merge 1 commit into from
+3 −0

Conversation

michaelasp
Copy link

  • One-line PR description: Update the beta requirements for KEP-4192 based on discussions in sig-apimachinery

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelasp
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from sttts August 11, 2025 21:04
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2025
@michaelasp
Copy link
Author

/cc @jpbetz
/cc @enj

@k8s-ci-robot k8s-ci-robot requested review from enj and jpbetz August 11, 2025 21:04
@michaelasp
Copy link
Author

Wasn't sure whether to add API changes into the beta requirements here or just update them in the KEP once we agree upon what the changes should be.

stlaz
stlaz reviewed Sep 4, 2025
View reviewed changes
keps/sig-api-machinery/4192-svm-in-tree/README.md
@@ -391,6 +391,9 @@ total:
- All of the above documented tests are complete
- Leader election to make sure new controller can work with both CRD and in-tree APIs.
- Using Garbage Collection Cache means using RV as an integer to validate the freshness of the cache. Approval from SigArch is required on this RV semantics.
- Unexpected event handling(i.e. interrupted migrations)
- Usage of [RealFIFO](https://github.com/kubernetes/kubernetes/pull/129568) and gating on feature enablement
- Ensuring that migration only runs for API objects that support Create/Update in its discovery document
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+the API needs to be revised

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wasn't sure whether to add this as a beta requirement or just have a separate PR for it altogether which would get reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedebongio fedebongio Awaiting requested review from fedebongio

@sttts sttts Awaiting requested review from sttts

@enj enj Awaiting requested review from enj

@jpbetz jpbetz Awaiting requested review from jpbetz

1 more reviewer

@stlaz stlaz stlaz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelasp @k8s-ci-robot @stlaz