-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up testing environment for gateway api #11179
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: James Strong <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
magefiles/steps/image.go
Outdated
if ARCH != runtime.GOARCH { | ||
ARCH = runtime.GOARCH | ||
} | ||
|
||
COMMIT_SHA, err := getCommitSHA() | ||
utils.CheckIfError(err, "Error Getting Commit sha") | ||
|
||
err = sh.RunV("docker", "build", | ||
"--no-cache", | ||
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE), | ||
"--build-arg", fmt.Sprintf("VERSION=%s", TAG), | ||
"--build-arg", fmt.Sprintf("TARGETARCH=%s", ARCH), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you are trying to override the ARCH, you can drop the if block here and assignment and use the runtime arch directly
if ARCH != runtime.GOARCH { | |
ARCH = runtime.GOARCH | |
} | |
COMMIT_SHA, err := getCommitSHA() | |
utils.CheckIfError(err, "Error Getting Commit sha") | |
err = sh.RunV("docker", "build", | |
"--no-cache", | |
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE), | |
"--build-arg", fmt.Sprintf("VERSION=%s", TAG), | |
"--build-arg", fmt.Sprintf("TARGETARCH=%s", ARCH), | |
COMMIT_SHA, err := getCommitSHA() | |
utils.CheckIfError(err, "Error Getting Commit sha") | |
err = sh.RunV("docker", "build", | |
"--no-cache", | |
"--build-arg", fmt.Sprintf("BASE_IMAGE=%s", BASE_IMAGE), | |
"--build-arg", fmt.Sprintf("VERSION=%s", TAG), | |
"--build-arg", fmt.Sprintf("TARGETARCH=%s", runtime.GOARCH), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, i could, had the default arm 64 but forgot metallb doesn't work with docker for Mac so had to go Linux server.
Signed-off-by: James Strong <[email protected]>
Signed-off-by: James Strong <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
@strongjz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
add mage testing framework for local gateway api testing, with metallb for loadbalancer.